Google Git
Sign in
chromium / external / github.com / luci / luci-go / eba3a76e7406cec606db3c8964428c059250110b
commiteba3a76e7406cec606db3c8964428c059250110b[log] [tgz]
authoriannucci <iannucci@chromium.org>Tue Jul 11 21:15:32 2017
committerCommit Bot <commit-bot@chromium.org>Tue Jul 11 21:15:32 2017
treec6e100b8cce8fb36893d35f7f475c7ebcc70efa9
parent494156a450069cafd4bee1bbd43f327a148cb698 [diff]
[milo] better ACL system for masters.

This way we can check to see if:
  * a user can see internal masters; OR
  * the master is public

Without revealing the existance of internal masters via timing attacks.

Plus it's simpler :)

R=dnj@chromium.org, hinoka@chromium.org, vadimsh@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2974263002
5 files changed
tree: c6e100b8cce8fb36893d35f7f475c7ebcc70efa9
  1. appengine/
  2. buildbucket/
  3. cipd/
  4. client/
  5. common/
  6. deploytool/
  7. dm/
  8. examples/
  9. grpc/
  10. hardcoded/
  11. infra/
  12. logdog/
  13. luci_config/
  14. lucictx/
  15. milo/
  16. mmutex/
  17. scheduler/
  18. scripts/
  19. server/
  20. swarming/
  21. tokenserver/
  22. tools/
  23. tumble/
  24. vpython/
  25. web/
  26. .travis.yml
  27. AUTHORS
  28. codereview.settings
  29. CONTRIBUTORS
  30. LICENSE
  31. luci-deploy.cfg
  32. pre-commit-go.yml
  33. PRESUBMIT.py
  34. README.md
  35. WATCHLISTS
README.md

luci-go: LUCI services and tools in Go

GoDoc Build Status Coverage Status

Installing

go get -u github.com/luci/luci-go/client/cmd/...
go get -u github.com/luci/luci-go/server/cmd/...

Code layout

  • /appengine/... contains AppEngine server code. It imports packages from /common/... and /server/....
  • /client/... contains all client code.
  • /common/... contains code and structures shared between all of /appengine/..., /client/... and /server/...; for example, the structures used by the server APIs. These are inherently APIs.
  • /deploytool/... contains the LUCI cloud services deployment tool.
  • /logdog/... contains LogDog client and server code, as well as APIs, protobufs, and support libraries.
  • /server/... contains standalone server code. Its packages are reusable by /appengine/....
  • /tools/... contains support tools used by other LUCI components.

Versioning

  • Branch go1 contains the stable code.
  • Branch master constains the latest code.

Contributing

  • Sign the Google CLA.
  • Make sure your user.email and user.name are configured in git config.
  • Install test-only packages: go get -u -t github.com/luci/luci-go/client/...
  • Install the pcg git hook: go get -u github.com/maruel/pre-commit-go/cmd/... && pcg

Run the following to setup the code review tool and create your first review:

git clone https://chromium.googlesource.com/chromium/tools/depot_tools.git $HOME/src/depot_tools
export PATH="$PATH:$HOME/src/depot_tools"
cd $GOROOT/github.com/luci/luci-go
git checkout -b work origin/master

# hack hack

git commit -a -m "This is awesome\nR=joe@example.com"
# This will ask for your Google Account credentials.
git cl upload -s
# Wait for LGTM over email.
# Check the commit queue box in codereview website.
# Wait for the change to be tested and landed automatically.

Use git cl help and git cl help <cmd> for more details.