817a5ecea39e1e458f7eb99fa2e5c691b396406c - external/github.com/neverware/shim-review

commit	817a5ecea39e1e458f7eb99fa2e5c691b396406c	[log] [tgz]
author	Paul Nardini <pnardini@neverware.com>	Wed Sep 23 00:13:22 2020
committer	Paul Nardini <pnardini@neverware.com>	Wed Sep 23 00:13:22 2020
tree	49ca323d06c933605ffd9babd91db85f0cf542c9
parent	35699911a28c493a60857773ff0e8672903d04e3 [diff]

tree: 49ca323d06c933605ffd9babd91db85f0cf542c9

README.md

This repo is for review of requests for signing shim. To create a request for review:

clone this repo
edit the template below
add the shim.efi to be signed
add build logs
commit all of that
tag it with a tag of the form “myorg-shim-arch-YYYYMMDD”
push that to github
file an issue at https://github.com/rhboot/shim-review/issues with a link to your tag

Note that we really only have experience with using grub2 on Linux, so asking us to endorse anything else for signing is going to require some convincing on your part.

Here's the template:

What organization or people are asking to have this signed:

Neverware Inc. (https://www.neverware.com)

What product or service is this for:

CloudReady

What's the justification that this really does need to be signed for the whole world to be able to boot it:

CloudReady is a Linux distro; we'd like to encourage people to boot our OS with secure boot enabled.

Who is the primary contact for security updates, etc.

Name: Nicholas Bishop
Position: software developer
Email address: nbishop@neverware.com
PGP key, signed by the other security contacts, and preferably also with signatures that are reasonably well known in the linux community: https://github.com/neverware/shim-review/blob/master/nbishop.key

Who is the secondary contact for security updates, etc.

Name: Paul Nardini
Position: Director of Engineering
Email address: pnardini@neverware.com
PGP key, signed by the other security contacts, and preferably also with signatures that are reasonably well known in the linux community: https://github.com/neverware/shim-review/blob/master/pnardini.key

What upstream shim tag is this starting from:

https://github.com/rhboot/shim/tree/shim-15.1

URL for a repo that contains the exact code which was built to get this binary:

https://github.com/rhboot/shim/tree/shim-15.1

What patches are being applied and why:

A patch for a missing ‘{’ in mok.c is applied to the shim-15.1 code base, as the build fails without it: https://github.com/neverware/shim-build/blob/v4/build-fix.patch

What OS and toolchain must we use to reproduce this build? Include where to find it, etc. We‘re going to try to reproduce your build as close as possible to verify that it’s really a build of the source tree you tell us it is, so these need to be fairly thorough. At the very least include the specific versions of gcc, binutils, and gnu-efi which were used, and where to find those binaries.

This repo contains the Dockerfile we use to build shim: https://github.com/neverware/shim-build/tree/v4

Which files in this repo are the logs for your build? This should include logs for creating the buildroots, applying patches, doing the build, creating the archives, etc.

build.log

Add any additional information you think we may need to validate this shim

Our shim-15.1 build is largely upstream's 15.1 with our new public certificate embedded. This build has been tested with our new grub, which is now up-to-date with fedora-33.