refs/tags/upstream/neverware-shim-20180820 - external/github.com/neverware/shim-review

commit	3de4849a45f5ed87c1e67a7bea84e2f1a1dd1e04	[log] [tgz]
author	Nicholas Bishop <nbishop@neverware.com>	Mon Aug 20 20:11:46 2018
committer	Nicholas Bishop <nbishop@neverware.com>	Mon Aug 20 20:11:46 2018
tree	34e943ef4946028dfc6b7b22874b2db19de7746e
parent	a6d873c9e203516e0074cecd8c910ac00d376c88 [diff]

tree: 34e943ef4946028dfc6b7b22874b2db19de7746e

README.md

This repo is for review of requests for signing shim. To create a request for review:

clone this repo
edit the template below
add the shim.efi to be signed
add build logs
commit all of that
tag it with a tag of the form “myorg-shim-arch-YYYYMMDD”
push that to github
file an issue at https://github.com/rhboot/shim-review/issues with a link to your tag

Note that we really only have experience with using grub2 on Linux, so asking us to endorse anything else for signing is going to require some convincing on your part.

Here's the template:

What organization or people are asking to have this signed:

Neverware Inc. (https://www.neverware.com)

What product or service is this for:

CloudReady

What's the justification that this really does need to be signed for the whole world to be able to boot it:

CloudReady is a Linux distro; we'd like to encourage people to boot our OS with secure boot enabled.

Who is the primary contact for security updates, etc.

Name: Nicholas Bishop
Position: software developer
Email address: nbishop@neverware.com
PGP key, signed by the other security contacts, and preferably also with signatures that are reasonably well known in the linux community: https://github.com/neverware/shim-review/blob/master/nbishop.key

Who is the secondary contact for security updates, etc.

Name: David Sayles
Position: director of software
Email address: dsayles@neverware.com
PGP key, signed by the other security contacts, and preferably also with signatures that are reasonably well known in the linux community: https://github.com/neverware/shim-review/blob/master/dsayles.key

What upstream shim tag is this starting from:

https://github.com/rhboot/shim/tree/15

URL for a repo that contains the exact code which was built to get this binary:

https://github.com/rhboot/shim/tree/15

What patches are being applied and why:

None

What OS and toolchain must we use to reproduce this build? Include where to find it, etc. We‘re going to try to reproduce your build as close as possible to verify that it’s really a build of the source tree you tell us it is, so these need to be fairly thorough. At the very least include the specific versions of gcc, binutils, and gnu-efi which were used, and where to find those binaries.

This repo contains the Dockerfile we use to build shim: https://github.com/neverware/shim-build/tree/v2

Which files in this repo are the logs for your build? This should include logs for creating the buildroots, applying patches, doing the build, creating the archives, etc.

build.log

Put info about what bootloader you're using, including which patches it includes to enforce Secure Boot here:

GRUB2. We are using https://github.com/rhboot/grub2/tree/fedora-28 with a couple of ChromeOS patches applied: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/4b5a6928cf7f351725139098c5faffd8fe64c3fe/sys-boot/grub/files/

Put info about what kernel you're using, including which patches it includes to enforce Secure Boot here:

Our kernel is based on v4.14. We have applied the secure boot patches from https://github.com/vathpela/linux/tree/secure-boot-4.14.