We‘re very wary of changes that increase the complexity of Ninja (in particular, new build file syntax or command-line flags) or increase the maintenance burden of Ninja. Ninja is already successfully used by hundreds of developers for large projects and it already achieves (most of) the goals we set out for it to do. It’s probably best to discuss new feature ideas on the mailing list or in an issue before creating a PR.
Generally it's the Google C++ Style Guide with a few additions:
#if __cplusplus >= 201103L
.using namespace std;
a lot in the past. For new contributions, please try to avoid relying on it and instead whenever possible use std::
. However, please do not change existing code simply to add std::
unless your contribution already needs to change that line of code anyway.///
for Doxygen (use \a
to refer to arguments).CanonicalizePath(string* path, string* err)
, the arguments are hopefully obvious).If you're unsure about code formatting, please use clang-format. However, please do not format code that is not otherwise part of your contribution.