commit bbe9cc837a46214adac6d4b905a6eaf42ab7b33e
author Daniel Lemire <daniel@lemire.me> Fri Feb 16 14:42:34 2024
committer Daniel Lemire <daniel@lemire.me> Fri Feb 16 14:42:34 2024
tree cc3b3e1c6c466ae71d1514249da4b5798f1df466
parent 3f6a54bfc95e5b8377bc6543c6488889ff73fbf1

fix: memcmp

tests/convert_utf8_to_utf16be_tests.cpp

diff --git a/tests/convert_utf8_to_utf16be_tests.cpp b/tests/convert_utf8_to_utf16be_tests.cpp
index 5d838cb..9f27c29 100644
--- a/tests/convert_utf8_to_utf16be_tests.cpp
+++ b/tests/convert_utf8_to_utf16be_tests.cpp
@@ -122,7 +122,7 @@
   std::unique_ptr<char16_t[]> utf16(new char16_t[utf16len]);
   size_t utf16size = implementation.convert_utf8_to_utf16be((const char*)utf8, 2, utf16.get());
   ASSERT_TRUE(utf16size == utf16len);
-  memcmp((const char*)utf16.get(), expected, 2);
+  ASSERT_TRUE(memcmp((const char*)utf16.get(), expected, 2) == 0);
 }
 
 

tests/convert_utf8_to_utf16le_tests.cpp

diff --git a/tests/convert_utf8_to_utf16le_tests.cpp b/tests/convert_utf8_to_utf16le_tests.cpp
index e433496..544a3ea 100644
--- a/tests/convert_utf8_to_utf16le_tests.cpp
+++ b/tests/convert_utf8_to_utf16le_tests.cpp
@@ -253,7 +253,7 @@
   std::unique_ptr<char16_t[]> utf16(new char16_t[utf16len]);
   size_t utf16size = implementation.convert_utf8_to_utf16le((const char*)utf8, 2, utf16.get());
   ASSERT_TRUE(utf16size == utf16len);
-  memcmp((const char*)utf16.get(), expected, 2);
+  ASSERT_TRUE(memcmp((const char*)utf16.get(), expected, 2) == 0);
 }
 
 int main(int argc, char* argv[]) {

tests/convert_valid_utf8_to_utf16be_tests.cpp

diff --git a/tests/convert_valid_utf8_to_utf16be_tests.cpp b/tests/convert_valid_utf8_to_utf16be_tests.cpp
index 4f849e0..8fd242a 100644
--- a/tests/convert_valid_utf8_to_utf16be_tests.cpp
+++ b/tests/convert_valid_utf8_to_utf16be_tests.cpp
@@ -109,7 +109,7 @@
   std::unique_ptr<char16_t[]> utf16(new char16_t[utf16len]);
   size_t utf16size = implementation.convert_valid_utf8_to_utf16be((const char*)utf8, 2, utf16.get());
   ASSERT_TRUE(utf16size == utf16len);
-  memcmp((const char*)utf16.get(), expected, 2);
+  ASSERT_TRUE(memcmp((const char*)utf16.get(), expected, 2) == 0);
 }
 
 int main(int argc, char* argv[]) {

tests/convert_valid_utf8_to_utf16le_tests.cpp

diff --git a/tests/convert_valid_utf8_to_utf16le_tests.cpp b/tests/convert_valid_utf8_to_utf16le_tests.cpp
index 12b6928..f803de6 100644
--- a/tests/convert_valid_utf8_to_utf16le_tests.cpp
+++ b/tests/convert_valid_utf8_to_utf16le_tests.cpp
@@ -163,7 +163,7 @@
   std::unique_ptr<char16_t[]> utf16(new char16_t[utf16len]);
   size_t utf16size = implementation.convert_valid_utf8_to_utf16le((const char*)utf8, 2, utf16.get());
   ASSERT_TRUE(utf16size == utf16len);
-  memcmp((const char*)utf16.get(), expected, 2);
+  ASSERT_TRUE(memcmp((const char*)utf16.get(), expected, 2) == 0);
 }
 
 int main(int argc, char* argv[]) {