commit | 324dd166b7c0b39d513026fa52d6280ac6d56770 | [log] [tgz] |
---|---|---|
author | Jaime Bernardo <jaime@janeasystems.com> | Sun Aug 06 19:04:36 2017 |
committer | Commit Bot <commit-bot@chromium.org> | Mon Aug 07 15:51:31 2017 |
tree | fb4c42492824c2a29fc9d7c69a293e8547a2fcd8 | |
parent | 4801a5331ae62da9769a327f11c4213d32fb0dad [diff] |
gyp: show descriptive Windows SDK detection error When building with Visual Studio 2017, gyp may fail with a non-descriptive message if Windows has stale registry keys for a version of Windows SDK that was previously uninstalled. This commit adds a specific warning message when the directory for a detected SDK version doesn't exist and adds some Fixes to avoid Python crashes that were blocking the detection of other SDK versions: - Only try to run listdir on a path if it exists and is a dir. - Avoid accessing names[0] if it has no elements. - Use %s instead of %o to print compatible_sdks (to avoid TypeError, since %o is the octal number format specifier in Python and %s can be used as a generic format specifier for objects). Refs: https://github.com/nodejs/node/pull/14597 Bug: https://github.com/nodejs/node/issues/14103 Change-Id: Ifd50fe239f65b7b4a2d69c1c02038bada03066cb Reviewed-on: https://chromium-review.googlesource.com/602133 Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org>
Documents are available at gyp.gsrc.io, or you can check out md-pages
branch to read those documents offline.