| commit | 5c270f76748e52bf8579316ee66b0facb4962628 | [log] [tgz] |
|---|---|---|
| author | Tobias Hahn <tobias.hahn@ableton.com> | Mon Apr 15 14:40:18 2019 |
| committer | Mark Mentovai <mark@chromium.org> | Thu Apr 18 14:16:11 2019 |
| tree | 28cfc2a6a6797614bbb623bd8fe7c21b5fb8e4f1 | |
| parent | 9f2a7bb115a19492554abaaa2a1d1715875bef66 [diff] |
Fix incorrect depfile path relativization While 'gyp dictates that commands are run from the base directory' (ninja.py:1613), ninja still expects the depfile path for the depfile that this command will create to be relative to the build directory. If the depfile argument doesn't contain special paths like <(PRODUCT_DIR), <(SHARED_INTERMEDIATE_DIR) or <(INTERMEDIATE_DIR), ExpandSpecial returns its argument unchanged. If it does contain one of these special paths, on the other hand, ninja will never find the correct depfile without this fix. Bug: 549 Change-Id: Idfae9dd1e7134720c5ce19fc8e4f877dde796d56 Reviewed-on: https://chromium-review.googlesource.com/c/external/gyp/+/1561250 Reviewed-by: Mark Mentovai <mark@chromium.org>
Documents are available at gyp.gsrc.io, or you can check out md-pages branch to read those documents offline.