Add some unconditional logging on the failure points when attaching
to a process so we'll always get messages in the console logs.  

Also make the "is frontboard process" / "is backboard process"
determination lazy, specifically take it out of the
MachProcess::AttachForDebug codepath when we are attaching to a
process, to simplify attaching.

<rdar://problem/47982516> 
<rdar://problem/48060134> 



git-svn-id: https://llvm.org/svn/llvm-project/lldb/trunk@354181 91177308-0d34-0410-b5e6-96231b3b80d8
3 files changed