| commit | 001b1e3cf01aa4befe011b7f17bcd22c12d4c8c4 | [log] [tgz] |
|---|---|---|
| author | Nico Weber <nicolasweber@gmx.de> | Fri Apr 06 16:43:49 2018 |
| committer | Nico Weber <nicolasweber@gmx.de> | Fri Apr 06 16:45:32 2018 |
| tree | dc94861ab8065feb21e438fb3a745cd0ed82fe59 | |
| parent | 04ba59b2ad986bd5765b14c5b497ccb0a2e909d4 [diff] |
Improve location of error messages around identifiers. Lexer::ReadIdent() now sets last_token_ before returning, like Lexer::ReadEvalString() does. So all "expected identifiers" and things that call ReadIdent (pool parser, rule parser, let parser, code parsing the rule name after a : in a build line) now point the "^ near here" at what was there instead of the previous last_token According to manifest_parser_perftest, this is perf-neutral.