commit | 77354b07e4ef608d0ca521d04b0408b5170dfdb8 | [log] [tgz] |
---|---|---|
author | Jean-Philippe Gravel <jpgravel@chromium.org> | Tue Feb 27 20:43:58 2024 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Feb 27 22:57:46 2024 |
tree | 17c70f72e9b573998cdfefa6e27e32945bd27093 | |
parent | ac566fe54a10c30567c9427e68ddf348c5460a3a [diff] |
Propagate the current transform when creating a side recording The 2D canvas uses an MemoryManagedPaintRecorder (a child class of InspectableRecordPaintCanvas) to record draw ops because it needs to be able to query the current matrix. InspectableRecordPaintCanvas keeps track of the current matrix by maintaining an SkNoDrawCanvas in parallel to the recording. When we open a layer in the 2D canvas, we create a side recording in which we store the layer content. This is needed so that we could present the canvas at any time by flushing all paint ops up to the first beginLayer (opened layers can't be flushed, they'll be presented later, after they are closed). When creating the side recording however, the SkNoDrawCanvas of the new recording has to be initialized with the same matrix as the main recording, or else, the layer's InspectableRecordPaintCanvas won't hold the correct transform. The 2D canvas uses a MemoryManagedPaintRecorder, but the SkNoDrawCanvas lives in the parent class, InspectableRecordPaintCanvas. MemoryManagedPaintRecorder can't therefore set the matrix on it's own. The SkNoDrawCanvas is an implementation detail of InspectableRecordPaintCanvas, it would be preferable to avoid exposing this via the class API. A better abstraction is to add CreateChildCanvas constructors, to delegate to the InspectableRecordPaintCanvas task of creating a canvas with the same size and matrix. Bug: 40249439 Change-Id: Ib3c0510e06d8f820f4d63469061546c1b140d2bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5324650 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Jean-Philippe Gravel <jpgravel@chromium.org> Cr-Commit-Position: refs/heads/main@{#1266025}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!