tree 6324a9cada0a8807273be72c6613f14624a3e52e
parent e1feca6a11ae00ae50af7666462b2c93a73ad5b3
author Mason Freed <masonf@chromium.org> 1630707300 -0700
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> 1630708231 -0700

Remove !important from <select> color rules

These were added in [1] in response to a bug [2] that was essentially
"you can style the checked option so that it is the same color as the
other options". And while that's true, I'm not sure why that's a good
reason to outlaw changes to color/background-color entirely. As
pointed out in comment [3] there, this CSS today would cause the
same issue:

  option {
    background: rgb(206, 206, 206);
  }

because it would match the existing :checked UA style. And because
of the !important rules, there would be no way to change the :checked
style to ensure contrast.

This was mostly attempted in [4], but that CL triggered some other
bugs, so this CL doesn't change the :focus styles at all. So this is
something of a partial-reland, without the :focus changes.

[1] https://src.chromium.org/viewvc/blink?revision=179782&view=revision
[2] https://crbug.com/398417
[3] https://bugs.chromium.org/p/chromium/issues/detail?id=398417#c8
[4] https://chromium-review.googlesource.com/c/chromium/src/+/3119649

Fixed: 562990
Bug: 398417
Bug: 1244986
Change-Id: If44345137867ee16d7e94ce796c4d2d2a3799461
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3130583
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#918265}