commit | a747e0292b02826258bcbfb3ab9528c60d527018 | [log] [tgz] |
---|---|---|
author | Oriol Brufau <obrufau@igalia.com> | Sat Sep 04 17:26:24 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Sat Sep 04 17:36:15 2021 |
tree | e07a0ee7c9d2bab7e08711397a2089414085adb1 | |
parent | 4935b8010a8121913c30bad6460b31a8554d9090 [diff] |
[cc] Recreate high resolution tiling w/o text when scale is not ideal CanRecreateHighResTilingForLCDTextAndRasterTranslation used to only be relevant when the raster transform changed its translation. The scale was 1D and equal to the tiling key, so it would always be ideal. Then it was fine to not recreate high resolution tilings if there was no text. However, in r872117 I added support for 2D scales, defining the key as the maximum component. Then it can happen that we find a previous tiling with the given key, but with a different scale. In that case, reusing the tiling just because it has no text can produce very poor results. So this patch changes that case to only reuse if the scale is ideal. Also, CanRecreateHighResTilingForLCDTextAndRasterTranslation is renamed to CanRecreateHighResTilingForLCDTextAndRasterTransform since it takes the scale into account. Bug: 1242860 TEST=external/wpt/css/css-transforms/transform-3d-scales-different-x-y-dynamic-002.html Change-Id: Ia68f90728a170f864fb6c0ff71b831293b887c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3141874 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/main@{#918387}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!