tree 213ff12a636048ba81f941f440548fcdfab7564e
parent e44c9f21d22b42534cd71cd47260aaeec7504ad9
author Xiaocheng Hu <xiaochengh@chromium.org> 1652200773 -0700
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> 1652201684 -0700

Fix block & unblock ordering when an inline style sheet mutates

When an inline <style> mutates, it calls AddPendingBlockingSheet() for
the new style sheet first, and then calls RemovePendingBlockingSheet()
for the old style sheet.

This used to be fine when those two methods were just adding /
subtracting some counters. However, after crrev.com/c/3503857, the two
methods become adding / removing the <style> element into / from the
RenderBlockingResourceManager class's set of pending elements, which
assumes that we never double-add or double-remove any element. Then the
relevant states are broken.

This patch reorders the call sites of the two methods to make sure we
remove it before re-adding it.

Fixed: 1323319
Change-Id: If28e35fb794e7bd2d77107ab4f8e867ad66d88ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3636301
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1001530}