tree 86287bc95f5bbc2281c48ddda275228dd5343fc1
parent 21487b9dbbbe86d6dc8fe400e8c59a7e7b8f7ff3
author Andres Perez <andresrperez@google.com> 1660843091 -0700
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> 1660844203 -0700

Generate globalAlpha effect via filters

Currently, there are two ways to produce an opacity effect in Canvas2D: set the globalAlpha property or use the opacity canvas filter. By unifying the paths for the two APIs, the resulting effects are guaranteed to be identical and are easier to maintain and debug. After reference and performance testing, it was decided to do the unification by producing the effect defined with globalAlpha via filters.

The new GetGlobalAlphaAsFilter method, added to CanvasRenderingContext2DState, creates an opacity PaintFilter the with the value specified by globalAlpha. The StateGetFilter method now can receive an additional argument to indicate whether to include this filter, in order to allow the use of this method to get the canvas filters defined by the user. When the argument is set to include the globalAlpha filter, the PaintFilter returned is the result of composing the regular user set filters with the one obtained with GetGlobalAlphaAsFilter. The inclusion of the globalAlpha value in the image_flags, which was the way in which the globalAlpha effect was applied previously, was removed.

Bug: 1344922
Change-Id: Id96acd1f9ae07d2cb3076d27503273ea7408b7a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3763215
Reviewed-by: Juanmi Huertas <juanmihd@chromium.org>
Commit-Queue: Andres Perez <andresrperez@google.com>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Reviewed-by: Aaron Krajeski <aaronhk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1036664}