commit | f18ed9341ab26c2fa298f90d54c21f612b9a8ecf | [log] [tgz] |
---|---|---|
author | Delan Azabani <dazabani@igalia.com> | Sat Sep 17 06:49:11 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Sat Sep 17 07:02:47 2022 |
tree | 59436657caaa552dcddab0a2c83cde6d0912ca1a | |
parent | 88a38ea656018181d68550f0d497f7a95fb4ae03 [diff] |
CSS highlight painting: use old spelling/grammar in some edge cases SVG decoration painting is broken for highlight pseudos, because it walks up the ancestors to find ‘fill’ and ‘stroke’ in a way that only makes sense for originating elements and tree-abiding pseudos, which can crash if a highlight pseudo has decorations but the originating content does not. This was fixed in CL:3646539, but the new spelling and grammar highlight painting in CL:3779861 reintroduced the bug. PaintOneSpellingGrammarDecoration also asserts that styles will exist for ::{spelling,grammar}-error, which is generally true due to the new rules in html.css, but the assertion can fail in non-HTML content or in HTML content with the wrong root (such as body with no html [2]). In both of these cases, it probably makes sense to paint the default spelling/grammar decorations anyway, but this is not yet possible because there’s no easy way to synthesise a TextDecorationInfo without a real ComputedStyle. Thankfully the old pre-CSS spelling/grammar decoration painting code has not yet been removed. This patch makes PaintOneSpellingGrammarDecoration use the old pre-CSS spelling/grammar decoration for SVG content and in the rare case where non-SVG content has no ::{spelling,grammar}-error styles. [1] https://github.com/w3c/svgwg/issues/894 [2] https://bucket.daz.cat/work/igalia/0/56.html LOW_COVERAGE_REASON=new logic is tested in WPT and wpt_internal Fixed: 1358810, 1359175 Change-Id: I33b3499b1c3c21c9b1619ba18ca78305fa9b27f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3899651 Reviewed-by: Philip Rogers <pdr@chromium.org> Commit-Queue: Delan Azabani <dazabani@igalia.com> Cr-Commit-Position: refs/heads/main@{#1048359}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!