tree 892b8f91964ec282c35f02d49cc673e9987da63c
parent 260b0d7d962af5c33594c3afa4f514af0aa5e56f
author Ting-Yu Lin <tlin@mozilla.com> 1703219922 +0000
committer moz-wptsync-bot <wptsync@mozilla.com> 1703266327 +0000

Fix subgrid position when the gap is larger than track size.

When the subgrid gap forces a track to have a negative size, the old code was
clamping the track-size (`mBase`) to 0, but it was still placing that track at
`mPosition` that reflected its theoretical negative-size (shifting it
startwards). This patch removes that startwards shift.

Note on the tests: the existing grid-gap-011.html doesn't test the code change
around `lastTrack`. That is, we still pass the test without the position fix to
`lastTrack`. Hence I added grid-gap-012.html, which is adapted from
grid-gap-011.html, but with the subgrid gap changed to 250px (larger than the 2x
track size to test the position of the last track). Both Chrome and Safari
already pass the test.

Differential Revision: https://phabricator.services.mozilla.com/D197084

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1841297
gecko-commit: d0a378b117e036c0bba7495151659c44c052ef13
gecko-reviewers: dholbert