tree 4a5a6e2aa1f0fcd5a2c31baee1e03ee4355049ab
parent f61ca76190eff03c2660a7525d04572f93191b18
author Anders Hartvoll Ruud <andruud@chromium.org> 1704368122 -0800
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> 1704369126 -0800

[@scope] Produce kScopeActivation relations for scoped nesting

When parsing style rules that are immediate children of an @scope rule,
any compound selector which contains either :scope or '&' is prepended
with RelationType::kScopeActivation. This relation is what triggers
the "figure out if we're indeed in scope, and what the scoping root is"-
behavior during SelectorChecker, and without the kScopeActivation, we'll
just fall back to the regular behavior for :scope (i.e. it matches :root
in the normal cases).

This CL fixes a bug which caused missing kScopeActivations for nested
style rules within @scope, e.g.:

  @scope (a) {
    b {
      /* :scope needs to refer to 'a' here */
      :scope:not(&) { ... }
    }
  }

This doesn't work, because we're basing the kScopeActivation emit/no-emit
decision on the nesting type of the *immediate* parent rule, which in this
case is CSSNestingType::kNesting. We need to know whether any ancestor
rule is an @scope rule, and so we propagate a flag for this, and base
the emit/no-emit decision on this instead.

Fixed: 1512217
Change-Id: I35d28489dd8255badd2e9a9c911fda3e2541bb52
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5164291
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Auto-Submit: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1242853}