commit | 41453f17f71dc87ae64693a9daa87eb2cd0033d4 | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Sat Jun 24 08:07:01 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Sat Jun 24 08:20:36 2023 |
tree | 709190406430f24bd81ebd4891227fe77efc2fe6 | |
parent | b7727490c96a87eb3f40fe43f266ad05368ab2b0 [diff] |
Use the block-in-inline layout result when considering breaks. The layout result for the line box that's wrapped around the block- in-inline isn't very useful when it comes to considering break points. In order to get access to any block break token inside, for instance, we need the layout result and fragment of the anonymous block, not the line box. We were making an incorrect decision to break before an element in MovePastBreakpoint() because of this bug. Since we failed to realize that the child had actually broken inside (since we didn't see the break tokens that were actually there), we'd instead check if the child was taller than the remaining space - which it was. So we ended up breaking before at a last-resort break point, instead of using the breakpoint that we had already found inside. This is a rather bizarre situation, and in this case it's caused by underlying bugs. But at least we will no longer freeze / crash, with this CL. We should also be able to remove code added by CL:4181113 from NGInlineLayoutAlgorithm::PlaceBlockInInline() (setting the break appeal there manually should no longer be necessary), now that we use the "right" layout result for fragmentation considerations. But since this CL is likely to be merged to older versions, let's keep it as safe and merge-friendly as possible. NGBoxFragmentBuilder::AddResult() should also call the new function LayoutResultForPropagation() instead of doing the work on its own, but for the same reason as above, leave it alone for now. Bug: 1453643 Change-Id: Iaca8269d46eeaa7dc222298d77873a9c051f71c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4638061 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1162074}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!