commit | d8a430f48a8ea112f0d5451d6feb02121001ef63 | [log] [tgz] |
---|---|---|
author | Dominic Farolino <dom@chromium.org> | Tue Aug 31 22:51:41 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Aug 31 23:26:30 2021 |
tree | 7746b66d86008119e38d8ba8eefd3e9bb7356589 | |
parent | 3a3861a77c2a76eb2250aa73261c0eb6901c383f [diff] |
Images: Add test for list of available image coalescing This CL adds a test ensuring that the list of available images is not used to coalesce an image request into a current in-flight request The HTML Standard's list of available images [1] is only added to once all of of the bytes of an image have been fetched, and the `load` event is about to be fired [2]. This means that if an image request A is currently in-flight, and an image request B is made for the exact same image, both requests should hit the network and not be coalesced. This is also explicitly the intention of the spec: "It is not used to avoid re-downloading the same image while the previous image is still loading." Currently all browsers fail this test likely due to the memory cache (unspecified) or some non-spec-conforming form of the "list of available images". We should consider changing the spec to allow in-flight request coalescing, however until that is done we should at least have a test codifying the current state of the specification. [1]: https://html.spec.whatwg.org/multipage/images.html#list-of-available-images [2]: https://html.spec.whatwg.org/multipage/images.html#:~:text=completely%20available%20state.-,Add%20the%20image%20to%20the%20list%20of%20available%20images%20using%20the%20key,-key%2C%20with%20the R=domenic@chromium.org Bug: 994329 Change-Id: I9479ef286435704108e80e78096d5418ab014767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3133524 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by: Domenic Denicola <domenic@chromium.org> Cr-Commit-Position: refs/heads/main@{#917004}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!