tree 95ed1a9c594d9c810d873dfd7bc64c951cadbb72
parent bb30d118adc1c7154c548a28e81d30723e0aaaa8
author Alexander Cooper <alcooper@chromium.org> 1635905449 -0700
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> 1635906420 -0700

Fix a few edge cases for XRRigidTransform

First, for sufficiently large DOMPointInit Values, it was impossible to
normalize the quaternion. This now throws an Invalid State error.

Second, for sufficiently large Translation values, the DCHECK for
IsInvertible, was failing. This triggered tests/debug builds, while on
production builds, it simply returned identity. This DCHECK has been
removed and replaced with a DLOG(ERROR) and an explicit return of an
identity inverse, to match the existing behavior while spec discussions
are ongoing as far as what to do in this case. It is worth noting, that
the "matrix" attribute that the page receives in cases such as this,
contains "invalid" (e.g. Infinity) values (indeed even before reaching
this case), due to the type mismatch, where DOMPointInit/the internal
representation are doubles, and the "matrix" attribute is a
Float32Array.

Bug: 1258611
Change-Id: I572ec27a4c176a0a1a7352c8cbdf92070dcf1080
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3257117
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/main@{#937665}