commit | 00132324e3ebe041437c7eca8cbcc36645f61a26 | [log] [tgz] |
---|---|---|
author | Ting-Yu Lin <tlin@mozilla.com> | Sat Feb 12 03:00:44 2022 |
committer | moz-wptsync-bot <wptsync@mozilla.com> | Sat Feb 12 09:56:06 2022 |
tree | 0f516da19fcfba16daa869ce0d470566362acab7 | |
parent | 4ad9284846e4c7f55cf72bd694cbd7b4364122e0 [diff] |
Part 2 - Fix available block-size for block children in block container with box-decoration-break:clone. If a block container has box-decoration-break:clone, its block-end border and padding (BP) are *usually* drawn at the block-end edge of the current column/page. Thus, when computing the available block-size for its children, we should subtract its block-end border BP from it. When I claim the block-end BP are *usually* drawn at the block-end edge of the column/page, the exception is when a block container with a definite block-size runs out of its block-size in a column/page. In this case, the block-end BP is drawn at the block-end edge of its content-box. This patch wires the effective content-box block-size computed in nsBlockFrame::Reflow() into BlockReflowInput's constructor, and we do not subtract its block-end border BP from the `mContentArea.BSize(wm)` when this case happens. `BlockReflowInput::ContentBSize()` is the correct available block-size to reflow the children, precomputed in BlockReflowInput's constructor. See https://searchfox.org/mozilla-central/rev/c12a59323ee46b29b90c9917a3a7a70ea714ffec/layout/generic/BlockReflowInput.cpp#118-126 The remove hunk was a hack, working only for ColumnSetWrapper with `box-decoration-break:clone`. It's no longer needed. Differential Revision: https://phabricator.services.mozilla.com/D138367 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1564726 gecko-commit: aeaea91a4f585bab45270b44079c2bba902be857 gecko-reviewers: dholbert, emilio
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!