tree 387e322cb1dafac33ec2fff41ff99ed16144031f
parent c46c9680c51fd9dd310578246febd44dad559d24
author Xianzhu Wang <wangxianzhu@chromium.org> 1547493494 -0800
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> 1547493859 -0500

Reland "Reland "[PE] Fix background-image on ::first-line""

This reverts commit 3edb3f1bbe315083871126bcbe4d422556b0d69f.

Fix by moving UpdateFirstLineImageObservers() from
CachedFirstLineStyle() into GetCachedPseudoStyle() to ensure
we update image observers for the correct object.

Original change's description:
> Revert "Reland "[PE] Fix background-image on ::first-line""
>
> This reverts commit f6facb87f009321e336fea1db249ad41f4116bb8.
>
> Reason for revert: Still can't ensure strictly paired AddClient/RemoveClient.
>
> Bug: 921337,921341
>
> Original change's description:
> > Reland "[PE] Fix background-image on ::first-line"
> >
> > This reverts commit 3b58524dfeb579392545998cbb64841138cc5a6e.
> >
> > The original patch failed to call RemoveClient for the background-image
> > in the first line style.
> >
> > Original change's description:
> > > Revert "[PE] Fix background-image on ::first-line"
> > >
> > > This reverts commit fe023954ad31e422d0deb4116d7867098e11b688.
> > >
> > > Reason for revert: crbug.com/920115
> > >
> > > Bug: 920115
> > >
> > > Original change's description:
> > > > [PE] Fix background-image on ::first-line
> > > >
> > > > This CL ensures correct handling of background-image on ::first-line
> > > > from style change to paint invalidation.
> > > >
> > > > Bug: 918881
> > > > Change-Id: I2e3a7bf60cb0f851b203fc7f5135c4186cc731a3
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/1396154
> > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > > > Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#620921}
> > >
> > > TBR=wangxianzhu@chromium.org,futhark@chromium.org
> > >
> > > Change-Id: Iba8387598922eaccd35f44bcaceac1cff59ea83a
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 918881
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1403315
> > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#621178}
> >
> > Bug: 920115, 918881
> > Change-Id: I3ea101ae09ad062de657a8917d77b1ec34e329e4
> > Reviewed-on: https://chromium-review.googlesource.com/c/1403316
> > Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#622298}
>
> TBR=wangxianzhu@chromium.org,futhark@chromium.org
>
> Change-Id: I6d31b858b2bf61bb123c6bdb09780f33e05b4878
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 920115, 918881
> Reviewed-on: https://chromium-review.googlesource.com/c/1407974
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622325}

Change-Id: I2509073937be3b1eb8f4bdc0d6f5151c93253851
Bug: 921337, 921341, 920115, 918881
Reviewed-on: https://chromium-review.googlesource.com/c/1408358
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622542}