tree d90d3c5c98cb63970d269d36b33eab15e0ffda24
parent 9b7ef11c54ca4ae4113c033aa1b0af2a44e4cc88
author Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> 1547552531 -0800
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> 1547552873 -0500

Make named constructors' |prototype|s have the right property descriptor

As per https://heycam.github.io/webidl/#named-constructors, a named
constructors "prototype" property should NOT be writable, configurable or
enumerable, yet we were creating a property with the opposite
characteristics.

Call v8::Object::DefineOwnProperty() rather than v8::Object::Set() so we can
pass the property descriptor values we want.

More tests for named constructors are coming in
https://github.com/web-platform-tests/wpt/pull/14841

While here, do some minor cleanups suggested in the review:
* Rename |interfacePrototype| to |interface_prototype| to follow Chromium's
  coding style
* Replace an if check for |result| with a CHECK(), as we are already calling
  ToChecked() when setting it.

Bug: 921633
Change-Id: Ie1f31c7eb456f45e113cff3048f43aea7e05e8ba
Reviewed-on: https://chromium-review.googlesource.com/c/1409552
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622814}