tree 51ab6628a107d4e30a29ac30872a1e7448e4344b
parent 30780f8ab19f090f86fac45707c3dfbdfd73e064
author Majid Valipour <majidvp@chromium.org> 1563546339 -0700
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> 1563547096 -0400

[scroll-snap] Improve/fix root propagation test

Note that the tests still fails in Chrome but that is going to be addressed
with a follow up CL that fixes propagation logic [1].

## General

- Move clean up logic to its own functional and declare it using "add_cleanup".
This way there is no need to assume ordering of test also clean up always run
even if test fails.

- Tests were using "start end" when only end is used. This is not needed and
confusing so changed to "none end" to make this clear.

- Use 800 as destination for scroll to not confuse it with 1000 which is the
  target position.

## Test 1

At this point body's writing-mode is still the default value i.e.
`horizontal-tb`. So inline axis is still "horizontal". This means that
`scroll-snap-type: inline mandatory` snaps horizontally. But the test
expected it to snap vertically which is not correct!

Fix: We should actually avoid depending on writing-mode in this test as it
keeps the test more focused on the actual thing that is being tests and also
avoids the problem. So use  "y mandatory" instead.

## Test 2

Added a check to this test to verify behavior on the non-snapping axis.
Also added a new test to check horizontal-tb which was present in some
from in the original test.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1704859

Change-Id: I330fb02ef4d81c82c5371bf608c1930568fb1dc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696190
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#679086}