tree 10996add7166cba3e9fd5593ab1cd3b36bd0e11b
parent 80e94e6d5113f3670e0b36c0a1fd905a43ce65d5
author Oriol Brufau <obrufau@igalia.com> 1576852661 -0800
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> 1576866618 -0800

[css-pseudo] Properly set 'display: inline-block' to outside ::marker

Before this patch, outside markers were assigned 'display: inline-block'
but this happened in two different places: in LayoutNGListItem for
markers with 'content: normal', and in StyleAdjuster for content ones.

However, this meant that 'getComputedStyle(el, "::marker").display'
would be 'inline' in the former case and 'inline-block' in the latter.

This patch fixes that issue by ensuring that StyleAdjuster runs for all
markers, assigning 'display: inline-block' to outside ones even when
'content: normal'.

This has a noticeable effect even if the CSSMarkerPseudoElement flag is
disabled: text decorations are no longer propagated to outside markers.
This is actually expected, since decorations shouldn't be propagated to
inline-block descendants. They were being propagated for markers with
'content: normal' because the code that stops the propagation either
wasn't running for unstyled markers, or for styled normal markers it was
running before 'display: inline-block' was assigned.

This change won't be a compat problem since none of Chromium legacy,
Firefox and Edge propagate text decorations to outside markers by
default. Doing it seemed a LayoutNG bug.

Spec: https://drafts.csswg.org/css-pseudo-4/#marker-pseudo
Spec: https://drafts.csswg.org/css-lists/#list-style-position
Spec: https://drafts.csswg.org/css-text-decor-4/#line-decoration

BUG=457718

TEST=external/wpt/css/css-pseudo/marker-content-016.html
TEST=external/wpt/css/css-pseudo/marker-display-computed.html

The marker-content-016 test fails in legacy since the 'content' property
is not supported yet in ::marker

Change-Id: Ia1396a4f6c5d9825dba5a6265c32096a7066fbed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1975887
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Cr-Commit-Position: refs/heads/master@{#726783}