commit | f1fc271ead2366fd2fbe8d8957cd9afa86b40a19 | [log] [tgz] |
---|---|---|
author | Hiroki Nakagawa <nhiroki@chromium.org> | Tue Feb 18 09:08:40 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Feb 18 09:21:52 2020 |
tree | 3e12815cc6381de24a3276e28c5ae2536df5e531 | |
parent | 6e4414df10377cbe9c6af902f8346afec3df9517 [diff] |
Revert "Reland "Worker: Add data URL tests for nested dedicated workers"" This reverts commit 1431d28a18a6bdd158ba9f05e7d372887a6039dd. Reason for revert: The tests still consistently time out on WebKit Linux Leak. Original change's description: > Reland "Worker: Add data URL tests for nested dedicated workers" > > The original patch was reverted because the tests with worker variant > (nested dedicated workers) consistently timed out on WebKit Linux Leak. > In general, nested dedicated workers are slow, and also WebKit Linux > Leak is slow. Probably this is the reason why the tests consistently > timed out. > > To mitigate it, this patch adds timeout=long in the WPT's META line in > addition to the original patch. > > For sheriff: If the tests still time out on WebKit Linux Leak, feel free > to revert this patch again. In that case, I'll attempt to separate the > tests into multiple files. > > Original change's description: > > Revert "Worker: Add data URL tests for nested dedicated workers" > > > > This reverts commit 1d73a2eb29cb7088b4920cf8958b6b3d053b093a. > > > > Reason for revert: Worker variant of tests appears to consistently timeout on WebKit Linux Leak (crbug.com/1052322) > > > > Original change's description: > > > Worker: Add data URL tests for nested dedicated workers > > > > > > This CL renames data-url.html to data-url.any.js in order to run the > > > tests on a dedicated worker. Previously these tests only ran on window. > > > > > > Bug: n/a > > > Change-Id: I4be0cfdddc01fa4865763868c4947ea63e62d491 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054656 > > > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > > > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#741367} > > > > TBR=nhiroki@chromium.org,shimazu@chromium.org > > > > Change-Id: I00481f9a51c672b4041364674d0bcad00d959c63 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: n/a > > Bug: 1052322 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057046 > > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > > Commit-Queue: Stephen McGruer <smcgruer@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#741417} > > Bug: 1052322 > Change-Id: I348ba1743f58a6f0fedf2b739a1cb6a574af6f2f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060356 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#742050} TBR=nhiroki@chromium.org,shimazu@chromium.org Change-Id: I09412305ad6d2093ffb6c489774552eb0bd58f3b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1052322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061577 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#742080}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
In the vast majority of cases the only upstream branch that you should need to care about is master
. If you see other branches in the repository, you can generally safely ignore them.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!