tree 28e87cbf3aff4a6c40e9757e3c89a1c9f826c493
parent a18247887493f153823ed7d9d85126bd55668bc1
author Henrik Boström <hbos@chromium.org> 1598510921 -0700
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> 1598512269 -0700

Revert "[Sheriff] Revert "[Perfect Negotiation] Surface session descriptions at the right time.""

This reverts commit 3dbd8ec27d4b3dbf0b53d534a3a180886196361f.

Reason for revert: I don't think this is the culprit and it looks like this test has been flaking for a couple of weeks, see:
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyWAsSBUZsYWtlIk1jaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZXh0ZXJuYWwvd3B0L3dlYnJ0Yy9wcm90b2NvbC9jcnlwdG8tc3VpdGUuaHR0cHMuaHRtbAw

More details here: https://bugs.chromium.org/p/chromium/issues/detail?id=1122106

Original change's description:
> [Sheriff] Revert "[Perfect Negotiation] Surface session descriptions at the right time."
>
> This reverts commit 3bc91ccc927f8eb887a84a1e59f34c88518ce2ab.
>
> Reason for revert: Failure of WebKit Linux ASAN build, and that's the suspect for root cause. See https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20ASAN/17329
>
> Original change's description:
> > [Perfect Negotiation] Surface session descriptions at the right time.
> >
> > This fixes another timing related issue that blocks Perfect Negotiation.
> >
> > Before this CL, current/pending local/remote description attributes do
> > blocking-invokes on the webrtc thread, fetching the most up-to-date
> > states. This can prematurely expose the result of "in-parallel"
> > operations that have not surfaced yet, such as:
> > - setLocalDescription
> > - setRemoteDescription
> > - addIceCandidate
> >
> > This CL fixes that by copying the SDP states when any of these
> > operations complete on the WebRTC thread and carry them over in the
> > PostTask to the main thread. Here, we store these snapshots in
> > "internal slots" (variables living on the main thread). With this CL,
> > reading SDP attributes from RTCPeerConnection is non-blocking and
> > spec-compliant.
> >
> > WPT test coverage added for the exact timing of SLD/SRD and other test
> > expectations are updated. addIceCandidate updating the SDP is already
> > covered by old WPTs.
> >
> > Bug: chromium:1110347
> > Change-Id: Id41ec354465525c6cedf631fe2209fe097148f60
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323359
> > Commit-Queue: Henrik Boström <hbos@chromium.org>
> > Reviewed-by: Harald Alvestrand <hta@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#801798}
>
> TBR=hta@chromium.org,hbos@chromium.org
>
> Change-Id: I4af12fd1430773ea3d134cfc37b9c5e736f20ed0
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: chromium:1110347
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377715
> Reviewed-by: Amr Aboelkher <amraboelkher@google.com>
> Commit-Queue: Amr Aboelkher <amraboelkher@google.com>
> Cr-Commit-Position: refs/heads/master@{#801822}

TBR=hta@chromium.org,hbos@chromium.org,amraboelkher@google.com

Change-Id: Ia0f82e0d1b4660cf0d3641aaa446127092c6e6f7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:1110347
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379192
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802114}