commit | 1794f2ee84cd9cbbac0daea76ee7f52b12381bdb | [log] [tgz] |
---|---|---|
author | Anders Hartvoll Ruud <andruud@chromium.org> | Mon Nov 02 16:19:31 2020 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Mon Nov 02 17:17:51 2020 |
tree | 09dcb9af52c43071ae229884441088a3067cfc31 | |
parent | f44e82893ffac9ff549fb44e09d1a9f0ccf9341d [diff] |
Support complex selectors in :not() Until now we've only supported a single compound selector as an argument to :not(). This CL adds support for complex selectors, based on the recent work on :is() and :where(). Parsing ------- Note that unlike :is() and :where(), :not() does not use the forgiving selector list behavior, but instead fails parsing the normal way. CSSSelectorParser now has both ConsumeNestedSelectorList and ConsumeForgivingNestedSelectorList for the two behaviors. Our ShadowDOMv0-disabling logic should apply to complex :not() as well, but for backwards compatibility, we need to allow it whenever :not() _doesn't_ have a complex argument. The TreatAsNonComplexArgumentToNot() was added to detect this, which replaces the previous function CSSParserSelector::IsSimple. (When v0 is removed, we can remove this mess as well). Invalidation ------------ There was a bug in ExtractInvalidationSetFeaturesFromSelectorList: we're supposed to ignore any extracted features inside a :not(). For example, for ".a :not(.b)", we should not add ".b" to the invalidation set for ".a". In ExtractInvalidationSetFeaturesFrom- SelectorList there was code that attempted to block the inner features from "crossing" the :not()-boundary, but it incorrectly used the *outer* pseudo-type. In other words, when considering ":not(.b)", the pseudo-type would be kUnknown, since we are not (yet) inside the :not(). Instead what we need to do is check the pseudo-type of of the currently held simple selector. Now that we "block" inner features correctly at the :not() boundary, the check in ExtractInvalidationSetFeaturesFromCompound is not needed anymore. This in turns means we can remove several PseudoType params, which is nice. Matching -------- Now traverses a CSSSelectorList and uses MatchSelector. Beyond that it just works. Bug: 1139865 Change-Id: Iea5513445e54303ba0685cffc3b52dabc115b7f1 I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/0alTkXvDCL8/m/-ClOGvOJBAAJ Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507549 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#823161}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
#testing
on irc.w3.org; includes participants located around the world, but busiest during the European working day; all discussion is archived hereIf you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to http://w3c-test.org/.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!