tree 561f267b6bd96a797bf88ead010f4d6f67356066
parent a709d05105870b4bec47fa391fa90fbd8617c475
author Masayuki Nakano <masayuki@d-toybox.com> 1615396568 +0000
committer moz-wptsync-bot <wptsync@mozilla.com> 1615415313 +0000

part 3: Ignore non-deletable ranges in `HTMLEditor::HandleDeleteSelection()

For making delete handlers simpler, and set better target ranges to the
corresponding `beforeinput` event, we should ignore non-editable ranges
before handling deletion.

This patch makes editor stop handling deleteion when a range crosses editing
host boundaries.  In this case, Gecko has done nothing, but fired
`beforeinput` event.  Note that Blink deletes editable contents in the range
**until** it meets first non-editable content, but I don't think this is
a good behavior because it makes things complicated.  Therefore, I filed
a spec issue: https://github.com/w3c/editing/issues/283

On the other hand, this behavior change causes different behavior in
https://searchfox.org/mozilla-central/source/editor/libeditor/crashtests/1345015.html

It tries to insert paragraph into `<html>` element, but our editor currently
does not support it.  Therefore, it hits `MOZ_ASSERT`.  Therefore, this patch
added a new check into `HTMLEditor::InsertParagraphSeparatorAsSubAction()`.

Differential Revision: https://phabricator.services.mozilla.com/D107588

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1677566
gecko-commit: 52735c1a72f80a35d9ede12967e0c8847e2d3f03
gecko-reviewers: m_kato