tree 3aaf89eaa8b0d5c50634b74bb31d1a94c4a9313e
parent 09da3f87a972bda79a1f4a542fc891a791735e6f
author Owen Min <zmin@chromium.org> 1616188071 -0700
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> 1616191144 -0700

Revert "Enable Paint Holding Cross Origin for tests"

This reverts commit 7aa2449e715557bf13b86b6ff489f9ffceeddb80.

Reason for revert: This may causes multiple flaky tests:

Windows:
https://ci.chromium.org/ui/p/chromium/builders/ci/Win%207%20Tests%20x64%20(1)/78657/overview
Linux:
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20Ozone%20Tester%20(X11)/28133/overview

Original change's description:
> Enable Paint Holding Cross Origin for tests
>
> The Paint Holding Cross Origin feature extends Paint Holding to most
> navigations. Paint Holding defers the first commit of rendering
> data from the main thread to the compositor until after First
> Contentful Paint, or a 500ms timeout, has occurred.
>
> From a test perspective, the most important change is related to input.
> We drop all input when not updating the document lifecycle and while
> deferring the commits. Many tests expect to navigate and then immediately
> process input, and these tests timeout or otherwise fail with
> Paint Holding.
>
> Three strategies have been employed to address this:
> - For many tests it is sufficient to add text to the html content
>   so that First Contentful Paint is reached upon load and commits
>   begin. This works well for most cases but unfortunately the
>   linux_chromeos_rel bot is still flaky, probably due to slower loading.
> - Some tests just need to wait for hit test data, using
>   WaitForHitTestData
> - In other cases we allow early input using the blink flag.
>
> Test coverage for Paint Holding is provided by essentially all
> tests that use input or require a rendered result, so there is
> little concern about using the early input flag in a few test suites.
>
> This change may cause increased flakiness, particularly on the
> linux-chromeos-rel bot and Android. Please assign flakiness bugs
> to schenney@ and ping if necessary.
>
> Bug: 1120158
> Change-Id: Ief45735c5bdb4d48d6554dcfc12e3b621355e080
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368282
> Reviewed-by: Clemens Arbesser <arbesser@google.com>
> Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
> Reviewed-by: Bo <boliu@chromium.org>
> Reviewed-by: Owen Min <zmin@chromium.org>
> Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
> Reviewed-by: Tommy Martino <tmartino@chromium.org>
> Commit-Queue: Stephen Chenney <schenney@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#864725}

Bug: 1120158
Change-Id: Ia1c24c7b2be34bf0a8f7a5ac72ecb692636d4c6b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2775893
Auto-Submit: Owen Min <zmin@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#864779}