commit | 703b6682f0c5bb3e054ceca8568a75d37516d805 | [log] [tgz] |
---|---|---|
author | Henrik Boström <hbos@chromium.org> | Wed Jul 28 15:46:35 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Jul 28 15:57:09 2021 |
tree | a563675fce3893ef649a32751ec4c1774d8a058f | |
parent | 8620992daa170d4dd9a0411efd67cc33ecd7bc72 [diff] |
Attempt to de-flake simulcast WPTs. I believe the reason for flakily timing out is that ramp-up does not happen quickly enough. Because I am unable to change the getUserMedia() resolution in external/wpt/webrtc/simulcast/simulcast.js (this causes timeout, either because the camera resolution is not supported by the fake capturer or because webrtc does not send QQVGA, not sure?) this CL changes the simulcast tests only to do 2 layers instead of 3. 2 layers instead of 3 should have a significantly lower ramp-up time in cases where ramp-up is not instant. The tests are already marked as having a long timeout so not sure how else to de-flake other than to reduce the bitrate. If any of the tests starts flaking again we should mark them all as flaky and file a common bug for all tests instead of having one crbug per test. Bug: chromium:1223773, chromium:1225643, chromium:1229785, chromium:1230534 Change-Id: I7a78ffc63a0521e4f971611d28c283c512371f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3057576 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#906200}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Pull requests are automatically mirrored except those that modify sensitive resources (such as .py
). The latter require someone with merge access to comment with “LGTM” or “w3c-test:mirror” to indicate the pull request has been checked.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!