commit | 7ecda2442fb2ad67d569bff77cd368fb71a7a838 | [log] [tgz] |
---|---|---|
author | Liviu Tinta <liviutinta@chromium.org> | Fri Aug 27 22:09:03 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Aug 27 23:26:42 2021 |
tree | 0fdb6e124f348dbf11e24513c382c7a6ba383afd | |
parent | f58c51b9a101036d8fc153a1ea307423480b3f50 [diff] |
Reland "Populate pointerId, pointerType for contextmenu event" This is a reland of a6d69d5243dd02afbd8ef02e5a5c557dd8c4a9e9 I believe the reason for the test failures when this landed the first time was related to how pointerId was populated for the contextmenu pointer event. With crrev.com/c/2889205 landed, we have a robust way to associate the gesture event sequence with the corresponding pointer event sequence. This CL uses the approach in crrev.com/c/2889205 to populate the pointerId for the contextmenu pointer event. Original change's description: > Populate pointerId, pointerType for contextmenu event > > For contextmenu as a pointer event pointerId and pointerType > were not populated. > > In this CL we are populating pointerId/pointerType for contextmenu > coming from touch and mouse. > For touch we use a similar approach to crrev.com/c/2800231 > for populating pointerId,pointerType for clicks generated in > GestureManager::HandleGestureTap. > The main change will be in EventHandler::SendContextMenuEvent > where we'll be passing id and pointer type to the call to > MouseEventManager::DispatchMouseEvent. This in turn will > populate pointerId and pointerType correctly when the contextmenu > PointerEvent is created. > > Bug: 1150442,1150441 > TEST: external/wpt/pointerevents/pointerevent_contextmenu_is_a_pointerevent.html > Change-Id: If2408d9cf0d5f00b08efcf2236ff7933472972ce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2874026 > Commit-Queue: Liviu Tinta <liviutinta@chromium.org> > Reviewed-by: Robert Flack <flackr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#881145} Bug: 1150442,1150441,1207709 Change-Id: Iffaa60373a3811a10f54ff123e64850801450883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3101585 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/main@{#916130}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!