commit | 8e786e0fc0da2378b76a26e3dbfd96dccd8fd636 | [log] [tgz] |
---|---|---|
author | Andreu Botella <andreu@andreubotella.com> | Tue Nov 23 17:58:23 2021 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Nov 23 18:18:43 2021 |
tree | 0f505f03906dc2c16935872317ad69b6f2825ff0 | |
parent | 480b9ac4b759470542c5e8606bd06e1557ec25b4 [diff] |
Fix TextCodecUTF8's error handling in EOF and across buffer boundaries When TextCodecUTF8 found a truncated sequence at EOF, it used to emit one replacement character per byte in the sequence, even when it was a prefix of a valid sequence. Additionally, in streaming mode, if it found a lead byte for which a valid sequence would span longer than the current available bytes, any processing of that sequence was deferred until all such bytes were available, even if errors could be detected earlier. Both issues are solved by always checking the validity of partial sequences. The approach used in this patch uses `DecodeNonASCIISequence` to find the length of the maximal subpart of a partial sequence, and if the length is equal to the partial sequence size and we're not at EOF, we don't emit the error. However, this does not work when a byte in the 0x80 to 0xC1 range is found in a lead position, since `NonASCIISequenceLength` wrongly returns 2 and `DecodeNonASCIISequence` isn't enough to determine whether the partial sequence is invalid. This is fixed by having `NonASCIISequenceLength` to return 0 in those cases. Another issue with this approach is that, since the outer do-while loops in the `Decode` method take `do_flush && partial_sequence_size` as a condition, if a non-ASCII lead byte is found whose valid sequences would span longer than the bytes we have, those bytes would not be processed until the next call to `Decode` if `do_flush` is false. But as it turns out, the `do_flush` condition is not in fact needed, and removing it fixes this issue. Fixed: 796697 Fixed: 978522 Change-Id: Ic5a78e4eca356fdc2ad4038eba9ffe455fddf3ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3263938 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/main@{#944572}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!