commit | e5cfd27e4a082ec75151f98f2ffcc99376b656e8 | [log] [tgz] |
---|---|---|
author | Javier Fernández García-Boente <jfernandez@igalia.com> | Wed Jan 19 20:13:40 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Wed Jan 19 20:30:11 2022 |
tree | 22a59fa60889f23634ab0b7370bdeccc2492305f | |
parent | 0b54c5a86bd34917a8114ce57043140deac652b4 [diff] |
Compute the NGLineInfo hang_width even if ignored in text alignment The NGLineInfo class has an attribute hang_width_ to store the width of the preserved trailing spaces. Theoretically, this value is intended to be used during text alignment, following the rules discussed and resolved in the CSS WG issue 3440 [1]. In this issue it's been discussed how to handle end-of-line pre-wrap spaces, which may hang and could affect the final result of the text alignment. However, we also use the NGLineInfo's attribute to compute the line box's inline size, as part of the NGInlineLayoutAlgorithm::CreateLine logic. Since we ignore the hanging spaces when using 'center' alignment, we don't compute it; this leads to an incorrect inline size of the fist line in the test case described in the bug 782638, which incorrectly overflows the box's fixed size, causing the scrollbar to be activated when it shouldn't. Since we always compute the hang_width now, we need to consider it also in the case of RTL scenarios, where we were assuming it was ignored depending on certain values of the text alignment. In order to avoid regressions, this CL also simplifies the line_box's inline_size computation performed in the CreateLine function, ignoring for now the text direction, we always subtract the hang_width Then, the inclusion or not of the hang_width will be decided where it should; the function NGInlineLayoutAlgorithm::ApplyTextAlign is the one responsible of implementing the rules agreed in the CSS WG issue mentioned before. https://github.com/w3c/csswg-drafts/issues/3440 Bug: 782638, 1278559 Change-Id: Ib1950533169fb9cabc6b7bb9e6925451eff2a767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3360876 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/main@{#961084}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!