commit | 20bc2b4b05987e980ec18f0130884f04aef71466 | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Thu Feb 03 08:38:30 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Thu Feb 03 08:52:29 2022 |
tree | 6a351c8afb943be994a54777425c75b5ad6df2e5 | |
parent | 17360749298fc8b9656536a972ed140841b93a2b [diff] |
Initial work on fragmenting NG tables. This introduces the general block fragmentation mechanisms to the table* layout algorithms. There are a couple of things missing, such as handling early-breaks, and break-before and break-after propagation from cells to the containing row. We also don't yet stretch / recalculate the row and section block-sizes when we insert a break inside that consumes additional space (e.g. when breaking before monolithic content such as line boxes). The biggest change is in the table layout algorithm itself. We need to include caption layout during regular child layout now, so that we break and resume correctly before / inside captions. Had to restructure the caption layout code, so that we can re-use it during actual table child layout. The table layout algorithm needed a special child iterator (table child layout order are ordered as top captions, table header, table bodies, table footer, bottom captions - regardless of DOM order). The section and row algorithms can use the regular block child iterator. However, since the table, table section and table row layout algorithms need a section / row / cell index, that's updated when we iterate over the children, and we now may skip finished children, the index calculation is now a bit more complicated. Let the child iterator class take care of this, instead of increasing it by one per iteration. We may want to reconsider how we do table-cell vertical alignment. Right now it performs fragment-based alignment (because that pretty much just worked without any effort), but we may want to do "global" alignment instead, so that contents of short cells in a fragmented row start in a subsequent row fragment, rather than always in the first one. Bug: 1078927 Change-Id: Iffe96022110b1bd6008676c3e46b78d33a94522c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3427690 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#966638}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!