tree 2f2ca6f4bc9406e9da5bf11c5f14950db6779826
parent 6461b27ad4bb479b8df78219aeb6a54aec6d02a8
author Masayuki Nakano <masayuki@d-toybox.com> 1644495733 +0000
committer moz-wptsync-bot <wptsync@mozilla.com> 1644529440 +0000

Make `nsRange::ExcludeNonSelectableNodes` stop using `ErrorResult

It never returns error since its return type is `void` and it does not take
out param whose type is `ErrorResult`.

Therefore, `ErrorResult` in it is used only for checking whether an error occurs
in the calling methods, but neither `SuppressException()` nor `StealNSResult()`
is called for avoiding assertions at destructing the instance.

For avoiding the assertion, and in this case, it should not use `ErrorResult`.
When the result is completely ignored, `IgnoreErrors()` should be used instead.
Otherwise, when it just needs to know whether an API call failed or not, it
should use `IgnoreErrors` to avoid the redundant calls of `ErrorResult` and
for the performance (`ErrorResult`'s destruction may appear in the profile if
it's used in a hot path).

Differential Revision: https://phabricator.services.mozilla.com/D138231

bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=1753786
gecko-commit: 0955a24d5c1cd8be95c879054ec415018fddaaaf
gecko-reviewers: mbrodesser