tree 053dc8724db2487012508411a4abeef0820ddfeb
parent 3f00a909b6e15e281fe3dbbac376542465cc5232
author Morten Stenshorne <mstensho@chromium.org> 1647458599 -0700
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> 1647465493 -0700

Keep the result of float pushed to the next fragmentainer.

We used to RemoveLastItem() when we found a float on a line when this
float had to be pushed to the next fragmentainer, in spite of creating a
break token for it. This meant that, under certain circumstances, we
would attempt to handle the float *again* on a subsequent line, creating
*another* break token for it, resulting in duplicate fragments.

Instead, keep the "positioned float" in NGInlineItemResults, marked as
needing a break before. Not keeping it would result in it being added as
an unpositioned float, which wouldn't help much, since we'd then attempt
to position it again after the line (where it wouldn't fit either, so
that this would just be another way of creating a duplicate break
token).

Instead of setting positioned_float.layout_result to nullptr when we
decide to break before it, just keep it. We used to treat that as having
to break before it. But we have the need_break_before flag anyway. Use
that instead.

Bug: 1305497
Change-Id: I6f82fc60c7784717fd85f07c4894dd850a5871ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3528737
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#981777}