tree 5c203eeb3b47c1691bc71ed87f708e0cf52642a4
parent 8986d0b7443dee8302ea58ef2e0d97fd7163dfde
author Mason Freed <masonf@chromium.org> 1649103698 -0700
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> 1649104577 -0700

Convert <embed hidden> into a proper boolean attribute

Prior to this CL, <embed hidden> would still be visible. Only the
special values of <embed hidden=yes> or <embed hidden=true> would
"hide" the <embed>. (And it would be "hidden" by making it zero-
size, presumably to not change loading behavior.)

After this CL, the 'hidden' attribute behaves as a normal
boolean attribute - presence of the attribute is interpreted as
a "true" value.

This appears to be per-spec:
  https://html.spec.whatwg.org/#the-embed-element
  https://html.spec.whatwg.org/#the-hidden-attribute
  https://html.spec.whatwg.org/#boolean-attribute

Gecko does not respect the 'hidden' attribute *at all* on the <embed>
element. WebKit behavior matches the *new* behavior here - it
treats 'hidden' as a regular boolean attribute, honoring it if present.
Because the spec matches this new behavior, and because WebKit already
agrees with the behavior, I'm treating this like a bug fix, and not
something that needs an I2S. It seems like quite a corner case for a
site to be using <embed hidden=dont> or something, and expecting the
embed not to be hidden.

Fixed: 1063756
Change-Id: I1fc11d0de6ff9e3cc2f7c0d3e438ab9fc929e36b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3565492
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/main@{#988645}