tree 8a78f85e7e8834b11a2952b2b133b7252188b68f
parent 7a885690240a2b7d67ec54f0aa164397bb18b52a
author Anders Hartvoll Ruud <andruud@chromium.org> 1651842008 -0700
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> 1651842882 -0700

Disable incremental styling for animated ComputedStyles

For ComputedStyles that are affected by animation effects, we also
store the corresponding *base style* on that animated ComputedStyle.
This currently interacts poorly with incremental styling, since we copy
the (potentially animated) ComputedStyle from the Element, which may
already have the base style stored. StyleResolver::ApplyAnimatedStyle
may then store *that* style as a base style again, potentially creating
an infinite chain of base styles.

This problem can't be reproduced with DCHECKs enabled, since we
call ApplyBaseStyleNoCache to verify that the incremental
ComputedStyle is equal to the ComputedStyle we would produce with a
full resolution. However, the diff is blind to to fields which aren't
generated, which includes the BaseData.

Bug: 1313554
Change-Id: I24ce40b7ec9a54f818098b21e1125f0071c11b24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3629398
Reviewed-by: Steinar H Gunderson <sesse@chromium.org>
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1000332}