commit | fdb347a7f5edb85d5782c54932c9e495444a807a | [log] [tgz] |
---|---|---|
author | Morten Stenshorne <mstensho@chromium.org> | Fri Aug 12 11:27:50 2022 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Aug 12 11:40:50 2022 |
tree | 004a02be87b98f36066b0c2a8c1a9834b0bb6110 | |
parent | cd26ed81191bad4f548128a092a825a25d00de3a [diff] |
Support replaced content in repeated (NG) table sections. For now we attempt to only support regular images, and prevent any other type of replaced content (including form elements) and scrollable containers from being repeated, so that we only paint / hit-test in the first fragmentainer. Or at least don't crash. This requires us to simplify the PaintInfo::FragmentToPaint() logic. We previously had some special code that DCHECKed that legacy objects don't create multiple fragments (and simply returned the first FragmentData), but since multiple fragments is now possible, we'll allow it, under the assumption that someone has set the correct fragment ID in PaintInfo when looking up FragmentData via LayoutObject. Also had to make some changes in pre-paint, so that we don't leave fragment traversal at NG objects, even if CanTraversePhysicalFragments() is false. This is mainly to avoid DCHECK failures -- we'll fail to get this right for certain types of repeated replaced content, but that's fine, as long as CanPaintMultipleFragments() returns false in such cases. This CL makes two existing tests pass. Also added a "tentative" correctness test for repeated images, and added a crash test for a lot of other types of repeated replaced content, and also repeated scrollable containers, as there are quite a few reasons why the engine doesn't support repeating those correctly. Bug: 1334547 Change-Id: Ia86a668b842f4566957b028a03dc51e641a58652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3826300 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1034415}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!