tree a1d678c1a7bf4d8c394f740e0b4e5d006cca4486
parent 45fd19926d0c278bad060478674b23c27fd77d4b
author Xiaocheng Hu <xiaochengh@chromium.org> 1665793418 -0700
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> 1665794340 -0700

Revert "Don't take snapshot in CSSScroll/ViewTimeline constructor"

This reverts commit a0391c51ec5cbea5aab72e0d732a3098996897b6.

Reason for revert: Causing build failures crbug.com/1374585

Original change's description:
> Don't take snapshot in CSSScroll/ViewTimeline constructor
>
> CSSScrolltimeline and CSSViewTime objects are created as part of style
> recalc. However, they currently takes scroll offset snapshot when
> constructed, which is not spec-compliant (spec says taking snapshot once
> per frame update before style recalc) and violates pipeline stages.
>
> Hence, this patch removes snapshot taking from the constructors.
>
> The behavior change is that if a scroll timeline is created due to a
> style change, it won't be activated in an immediate getComputedStyle()
> call, but need to wait until the next frame update. This aligns with
> scroll offset changes. As a result:
> - Many web tests add waitForNextFrame() before getComputedStyle()
> - A unit test is changed into web test, because snapshotting is not
>   part of LocalFrameView::UpdateLifecyclePhases(), but current part of
>   update animation steps.
>
> Bug: 1371217
> Change-Id: Idb0397f241ae579b580c71b01889e92fb7471bde
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3935343
> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
> Reviewed-by: Kevin Ellis <kevers@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1058924}

Bug: 1371217,1374585
Change-Id: I067597633a3e03eace5522454c20fe6cc5149693
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3956549
Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Owners-Override: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1059546}