commit | 63e0e7019a119d75308e436bcec179c6cc40edae | [log] [tgz] |
---|---|---|
author | L. David Baron <dbaron@chromium.org> | Fri Jun 30 16:43:51 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Fri Jun 30 16:59:44 2023 |
tree | 5468b45e5e055550ab9f82a6c0fe32e915f62c13 | |
parent | bc5db6d7d53d259bc13682874f5790d5ac297950 [diff] |
Fix two custom elements tests to avoid depending on undefined ordering. Each test file has a single test that is currently failing identically in both Chromium and Gecko, while passing in WebKit. The tests that fail invoke: document.open(URL, "_self", ""); in a custom element constructor, and then rely on a script element *following* the custom element to be executed. This change fixes the test to avoid depending on that following script, but instead run the necessary code in the custom element constructor. (Only the test that does the document.open(URL, "_self", "") call needs this change, but the change affects all the tests in these files.) I believe the current test is depending on undefined behavior because (although I fully admit I'm skimming relatively long lists of complex steps in the HTML specification quite quickly) the document.open call is specified at https://html.spec.whatwg.org/multipage/C#dom-document-open-window which invokes https://html.spec.whatwg.org/multipage/C#window-open-steps where either step 12.6 or 13.1.3 are the same and invoke https://html.spec.whatwg.org/multipage/C#navigate . Step 19 of that algorithm is run "in parallel"), and step 19.3 invokes https://html.spec.whatwg.org/multipage/C#abort-a-document which in turn invokes https://html.spec.whatwg.org/multipage/C#abort-a-parser which I believe will stop later scripts from executing. The definition of "in parallel" is explicitly undefined at https://html.spec.whatwg.org/multipage/C#in-parallel so it's not clear when the parser is aborted relative to other things. I think this means that either the Gecko/Chromium behavior of aborting the parser before executing the following script, or the WebKit behavior of aborting at some later time, are both permitted. Fixed: 1365368 Fixed: https://bugzilla.mozilla.org/show_bug.cgi?id=1819922 Fixed: https://bugzilla.mozilla.org/show_bug.cgi?id=1819925 Change-Id: Ied396b36e5b7466de7ef98b9ab4559c9556be995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4661389 Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: David Baron <dbaron@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1164733}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!