tree 8b0e0f2d391d8ce042dbdbb863eee29dceced3c4
parent 05f75638b00d12693b50474a97f7caf4c41a7f55
author Steinar H. Gunderson <sesse@chromium.org> 1693485793 -0700
committer Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> 1693486788 -0700

Fix an overly aggressive DCHECKs for whitespace in custom properties.

ParseDeclarationValue() is responsible for handing back a string
that has neither leading nor trailing whitespace. Stripping
trailing whitespace is handled by StripTrailingWhitespaceAndComments(),
which then has a DCHECK verifying that the leading whitespace had been
stripped earlier in the process, so that we returned without either:

  [no leading whitespace here]some text blabla[any trailing spaces]

However, if the result is the empty string (“some text blabla” is empty),
the test would think that the “any trailing spaces” part was actually
part of leading whitespace that it didn't strip, and thus error out.

We fix this by simply moving the check for no leading whitespace
to the end of the function, after stripping the trailing. Thus,
we care more about the invariant at the end of the function, which is
what is important.

Fixed: 1476811
Change-Id: Icc1cd33ba0e33cf0251821515bfc58728043c20e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4827525
Commit-Queue: Steinar H Gunderson <sesse@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1190675}