commit | 27ccadd96797aec13652caaeaab3a428c06ab2d3 | [log] [tgz] |
---|---|---|
author | Mason Freed <masonf@chromium.org> | Tue Oct 03 19:14:13 2023 |
committer | Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> | Tue Oct 03 19:32:29 2023 |
tree | ed9fcaeaf824687e40cc0eb26dd6bc092c7a3166 | |
parent | 592f7b1cf7c9fb40c514940950ae2120339d4251 [diff] |
Optimize several things about DOM Parts [1/2] See [1] for details. This CL makes these changes: - Stop maintaining “live” parts lists across DOM mutations. This is controlled by a new feature flag, DOMPartsAPIActivePartTracking, that when disabled, short-circuits all of the part list maintenance code during DOM mutations. This means that if DOM nodes that are connected to parts are moved around in the DOM, including being removed from the document, the cached parts list does not change. - Update ToV8HelperSequence to work directly with Deques, and get rid of getParts() code to convert to a HeapVector. - Optimize ToV8HelperSequence to use iterators instead of array indexing, which should also speed up all sequence bindings. (TBD) - Change from FrozenArray<Part> to sequence<Part>. This eliminated the overhead of Object::SetIntegrityLevel(), which was ~29% of the total getParts() time. - Add a fast path for PartRoot.replaceChildren when all children are being removed. - Inline IsValid(). - Call InsertBefore() instead of before() to avoid some extra validity checks. This required making ConvertNodeUnionsIntoNode public. - Add PartRoot.getPartNode(n), which allows direct access to a single Part's Node, to avoid wrapping up the entire parts list. [1] https://docs.google.com/document/d/1wSbBV6tS-KLlHWxaK_FmEJFOwkY-pb8_YDoFJgDrbMg/edit Bug: 1453291 Change-Id: I3df15b2a552fe9c2793a7f7f2095d632bcea8326 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4878048 Reviewed-by: Joey Arhar <jarhar@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1204772}
The web-platform-tests Project is a cross-browser test suite for the Web-platform stack. Writing tests in a way that allows them to be run in all browsers gives browser projects confidence that they are shipping software that is compatible with other implementations, and that later implementations will be compatible with their implementations. This in turn gives Web authors/developers confidence that they can actually rely on the Web platform to deliver on the promise of working across browsers and devices without needing extra layers of abstraction to paper over the gaps left by specification editors and implementors.
The most important sources of information and activity are:
wpt:matrix.org
matrix channel; includes participants located around the world, but busiest during the European working day.If you'd like clarification about anything, don't hesitate to ask in the chat room or on the mailing list.
Clone or otherwise get https://github.com/web-platform-tests/wpt.
Note: because of the frequent creation and deletion of branches in this repo, it is recommended to “prune” stale branches when fetching updates, i.e. use git pull --prune
(or git fetch -p && git merge
).
See the documentation website and in particular the system setup for running tests locally.
The wpt
command provides a frontend to a variety of tools for working with and running web-platform-tests. Some of the most useful commands are:
wpt serve
- For starting the wpt http serverwpt run
- For running tests in a browserwpt lint
- For running the lint against all testswpt manifest
- For updating or generating a MANIFEST.json
test manifestwpt install
- For installing the latest release of a browser or webdriver server on the local machine.wpt serve-wave
- For starting the wpt http server and the WAVE test runner. For more details on how to use the WAVE test runner see the documentation.On Windows wpt
commands must be prefixed with python
or the path to the python binary (if python
is not in your %PATH%
).
python wpt [command]
Alternatively, you may also use Bash on Ubuntu on Windows in the Windows 10 Anniversary Update build, then access your windows partition from there to launch wpt
commands.
Please make sure git and your text editor do not automatically convert line endings, as it will cause lint errors. For git, please set git config core.autocrlf false
in your working tree.
The master branch is automatically synced to wpt.live and w3c-test.org.
Save the Web, Write Some Tests!
Absolutely everyone is welcome to contribute to test development. No test is too small or too simple, especially if it corresponds to something for which you've noted an interoperability bug in a browser.
The way to contribute is just as usual:
git checkout -b topic
../wpt lint
as described above.If you spot an issue with a test and are not comfortable providing a pull request per above to fix it, please file a new issue. Thank you!