commit | 528a834ef079e0821c76b6bb256ddc48602320ea | [log] [tgz] |
---|---|---|
author | perkj <perkj@webrtc.org> | Fri Mar 03 08:01:48 2017 |
committer | Commit bot <commit-bot@chromium.org> | Fri Mar 03 08:01:48 2017 |
tree | 7b96ad57522da47750e9dbbbc59f96d1efdf5e6b | |
parent | 6e10fd6b6baeb1b4dbd19474234d27170e9d7818 [diff] |
Revert of BlankDetectorDesktopCapturerWrapper to detect a blank DesktopFrame (patchset #7 id:180001 of https://codereview.webrtc.org/2709523003/ ) Reason for revert: Misses deps for RTC_HISTOGRAM in Chrome. email sent separately. Also see https://codereview.chromium.org/2725143004/. Original issue's description: > BlankDetectorDesktopCapturerWrapper to detect a blank DesktopFrame > > DXGI capturer highly depends on video adapter and its driver, as well as Windows > itself. I recently found it cannot work on my virtualbox instance any more, > which indicates it may not work well on some specific systems. What worse is, > the APIs do not return a failure in such case. > > So this change adds a BlankDetectorDesktopCapturerWrapper, which samples several > pixels in the frame returned by a DesktopCapturer implementation. If all the > pixels selected are blank, this wrapper returns a failure. A typical usage is to > combine BlankDetectorDesktopCapturerWrapper with FallbackDesktopCapturerWrapper, > and use GDI capturer in case of failure. > > Usually less than 500 pixels are checked, so the > BlankDetectorDesktopCapturerWrapper should not impact the capturer performance. > > This change is expected to resolve bug 682112 in another dimension. > > BUG=682112 > > Review-Url: https://codereview.webrtc.org/2709523003 > Cr-Commit-Position: refs/heads/master@{#16984} > Committed: https://chromium.googlesource.com/external/webrtc/+/c4e9d210b3516c7b2faa32f24409a2e626599255 TBR=sergeyu@chromium.org,zijiehe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=682112 Review-Url: https://codereview.webrtc.org/2726983005 Cr-Commit-Position: refs/heads/master@{#16993}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others. This page is maintained by the Google Chrome team.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.