| commit | aea9293fd45bced832862d544f34888c07d7bf65 | [log] [tgz] |
|---|---|---|
| author | deadbeef <deadbeef@webrtc.org> | Tue May 23 19:55:03 2017 |
| committer | Commit bot <commit-bot@chromium.org> | Tue May 23 19:55:03 2017 |
| tree | 3c5df006a0f62e8163f0ac56d760b34d2e8eef08 | |
| parent | b34f6a8520de5e4813e7f3e7cd2d2d7cb7d8c01f [diff] |
Revert of Fixing potential AsyncInvoker deadlock that occurs for "reentrant" invocations. (patchset #3 id:40001 of https://codereview.webrtc.org/2885143006/ ) Reason for revert: Causes a new TSan race warning. Will reland after fixing. Note this is the same race as will be fixed by https://codereview.webrtc.org/2876273002/. Original issue's description: > Fixing potential AsyncInvoker deadlock that occurs for "reentrant" invocations. > > The deadlock occurs if the AsyncInvoker is destroyed on thread A while > a task on thread B is running, which AsyncInvokes a task back on thread > A. > > This was causing pending_invocations_ to end up negative, because > an AsyncClosure that's never added to a thread's message queue (due to > the "destroying_" flag) caused the count to be decremented but not > incremented. > > BUG=None > > Review-Url: https://codereview.webrtc.org/2885143006 > Cr-Commit-Position: refs/heads/master@{#18225} > Committed: https://chromium.googlesource.com/external/webrtc/+/ef37ca5fb3431864130de3c2fd0ff865f9eb47dd TBR=nisse@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Review-Url: https://codereview.webrtc.org/2904543003 Cr-Commit-Position: refs/heads/master@{#18248}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.