| commit | 157e76f8a143e597fcfc37fec7b09e8f5db5ec74 | [log] [tgz] |
|---|---|---|
| author | Taylor Brandstetter <deadbeef@webrtc.org> | Tue Oct 17 16:32:20 2017 |
| committer | Commit Bot <commit-bot@chromium.org> | Tue Oct 17 20:18:31 2017 |
| tree | d726db819dcebabd8582b361e126fa20f0ec5968 | |
| parent | 39260c4a6b99d0dc45eadc7d750412e6454ae9cf [diff] |
Fix issue in AndroidNetworkMonitor for Wi-Fi Direct socket binding. AndroidNetworkMonitor::BindSocketToNetwork incorrectly checks if the socket_fd is NETWORK_UNSPECIFIED, when it should instead be checking if the network_handle is that. This causes the PhysicalSocket to think that it has succesfully bound to the port, when it really has not. This stops IceCandidates from being created for these addresses (although a socket is listening). The net result of this is that webrtc connections don't work when both peers are using Wifi-Direct to communicate, although we didn't notice this previously since we were using Wifi-Direct only on one side. TBR=pthatcher@webrtc.org Bug: webrtc:8403 Change-Id: Ibe8f5424654ac9db1f79927ba7ac241fd40d9cba Reviewed-on: https://webrtc-review.googlesource.com/12442 Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org> Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org> Cr-Commit-Position: refs/heads/master@{#20331}
WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.
Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.
The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.
See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.