Fix issue in AndroidNetworkMonitor for Wi-Fi Direct socket binding.

AndroidNetworkMonitor::BindSocketToNetwork incorrectly checks if the
socket_fd is NETWORK_UNSPECIFIED, when it should instead be checking
if the network_handle is that. This causes the PhysicalSocket to think
that it has succesfully bound to the port, when it really has not.
This stops IceCandidates from being created for these addresses
(although a socket is listening).

The net result of this is that webrtc connections don't work when both
peers are using Wifi-Direct to communicate, although we didn't notice
this previously since we were using Wifi-Direct only on one side.

TBR=pthatcher@webrtc.org

Bug: webrtc:8403
Change-Id: Ibe8f5424654ac9db1f79927ba7ac241fd40d9cba
Reviewed-on: https://webrtc-review.googlesource.com/12442
Commit-Queue: Taylor Brandstetter <deadbeef@webrtc.org>
Reviewed-by: Taylor Brandstetter <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#20331}
1 file changed
tree: d726db819dcebabd8582b361e126fa20f0ec5968
  1. .clang-format
  2. .git-blame-ignore-revs
  3. .gitignore
  4. .gn
  5. .vpython
  6. AUTHORS
  7. BUILD.gn
  8. CODE_OF_CONDUCT.md
  9. DEPS
  10. LICENSE
  11. LICENSE_THIRD_PARTY
  12. OWNERS
  13. PATENTS
  14. PRESUBMIT.py
  15. README.chromium
  16. README.md
  17. WATCHLISTS
  18. api/
  19. audio/
  20. build_overrides/
  21. call/
  22. codereview.settings
  23. common_audio/
  24. common_types.cc
  25. common_types.h
  26. common_video/
  27. data/
  28. examples/
  29. infra/
  30. license_template.txt
  31. logging/
  32. media/
  33. modules/
  34. ortc/
  35. p2p/
  36. pc/
  37. presubmit_test.py
  38. presubmit_test_mocks.py
  39. pylintrc
  40. resources/
  41. rtc_base/
  42. rtc_tools/
  43. sdk/
  44. stats/
  45. style-guide.md
  46. system_wrappers/
  47. test/
  48. tools_webrtc/
  49. typedefs.h
  50. video/
  51. voice_engine/
  52. webrtc.gni
  53. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See http://www.webrtc.org/native-code/development for instructions on how to get started developing with the native code.

More info