Prevent pointer from being sent in the clear over SCTP.

We were using the address of the SctpTransport object as
the sconn_addr field in usrsctp, which is used to get access to
the SctpTransport object in various callbacks.

However, this address is sent in the clear in the SCTP cookie,
which is undesirable.

This change uses a monotonically increasing id instead, which
is mapped back to a SctpTransport using a SctpTransportMap helper
class.

Bug: chromium:1076703
Change-Id: Iffb23fdbfa13625e921a9fd5500fe772b4d4015f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/176422
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Commit-Queue: Taylor <deadbeef@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#31449}
2 files changed
tree: d7cda502d265b4a45c881858ce315f161d553be3
  1. .clang-format
  2. .git-blame-ignore-revs
  3. .gitignore
  4. .gn
  5. .vpython
  6. AUTHORS
  7. BUILD.gn
  8. CODE_OF_CONDUCT.md
  9. DEPS
  10. ENG_REVIEW_OWNERS
  11. LICENSE
  12. OWNERS
  13. PATENTS
  14. PRESUBMIT.py
  15. README.chromium
  16. README.md
  17. WATCHLISTS
  18. abseil-in-webrtc.md
  19. api/
  20. audio/
  21. build_overrides/
  22. call/
  23. codereview.settings
  24. common_audio/
  25. common_types.h
  26. common_video/
  27. data/
  28. docs/
  29. examples/
  30. license_template.txt
  31. logging/
  32. media/
  33. modules/
  34. native-api.md
  35. p2p/
  36. pc/
  37. presubmit_test.py
  38. presubmit_test_mocks.py
  39. pylintrc
  40. resources/
  41. rtc_base/
  42. rtc_tools/
  43. sdk/
  44. stats/
  45. style-guide.md
  46. style-guide/
  47. system_wrappers/
  48. test/
  49. tools_webrtc/
  50. video/
  51. webrtc.gni
  52. webrtc_lib_link_test.cc
  53. whitespace.txt
README.md

WebRTC is a free, open software project that provides browsers and mobile applications with Real-Time Communications (RTC) capabilities via simple APIs. The WebRTC components have been optimized to best serve this purpose.

Our mission: To enable rich, high-quality RTC applications to be developed for the browser, mobile platforms, and IoT devices, and allow them all to communicate via a common set of protocols.

The WebRTC initiative is a project supported by Google, Mozilla and Opera, amongst others.

Development

See here for instructions on how to get started developing with the native code.

Authoritative list of directories that contain the native API header files.

More info