Remove semantic_properties from third party proto
PiperOrigin-RevId: 375701517
Change-Id: Ib9f1607843fda73407f47d7e2385ed24f09fc5f8
diff --git a/src/main/proto/search/now/wire/feed/feed_action.proto b/src/main/proto/search/now/wire/feed/feed_action.proto
index b9a4150..7834322 100644
--- a/src/main/proto/search/now/wire/feed/feed_action.proto
+++ b/src/main/proto/search/now/wire/feed/feed_action.proto
@@ -20,11 +20,11 @@
import "src/main/proto/search/now/wire/feed/action_payload.proto";
import "src/main/proto/search/now/wire/feed/content_id.proto";
-import "src/main/proto/search/now/wire/feed/semantic_properties.proto";
option java_package = "com.google.search.now.wire.feed";
option java_outer_classname = "FeedActionProto";
+// Next Id: 7
message FeedAction {
// The Id for the content that this action was triggered on.
optional ContentId content_id = 1;
@@ -32,11 +32,7 @@
optional ActionPayload action_payload = 4;
// Client-generated data that pertains to the action.
optional ClientData client_data = 5;
- // Fields beyond ID needed to determine uniqueness for the card or collection.
- // Opaque to the client, round-tripped from the server.
- optional SemanticProperties semantic_properties = 6;
- // Next Id: 7
- reserved 2, 3;
+ reserved 2, 3, 6;
// The data the client provides to the server.
message ClientData {
diff --git a/src/main/proto/search/now/wire/feed/feed_action_query_data.proto b/src/main/proto/search/now/wire/feed/feed_action_query_data.proto
index 55a72b8..98e6d63 100644
--- a/src/main/proto/search/now/wire/feed/feed_action_query_data.proto
+++ b/src/main/proto/search/now/wire/feed/feed_action_query_data.proto
@@ -15,7 +15,6 @@
syntax = "proto2";
import "src/main/proto/search/now/wire/feed/action_type.proto";
-import "src/main/proto/search/now/wire/feed/semantic_properties.proto";
package search.now.wire.feed;
@@ -43,14 +42,12 @@
// A unique set of tables associated with the content.
repeated string unique_table = 4;
- // A unique set of SemanticProperties associated with the content that the
- // action was performed on. This data is not altered by the client.
- repeated SemanticProperties unique_semantic_properties = 5;
-
// The content that the action was performed on. The identity of the content
// can be created by combining unique_id, unique_content_domain, and
// unique_table.
repeated FeedActionQueryDataItem feed_action_query_data_item = 6;
+
+ reserved 5;
}
// Data describing the individual content that was acted upon.
diff --git a/src/main/proto/search/now/wire/feed/payload_metadata.proto b/src/main/proto/search/now/wire/feed/payload_metadata.proto
index 587a4f9..17856b8 100644
--- a/src/main/proto/search/now/wire/feed/payload_metadata.proto
+++ b/src/main/proto/search/now/wire/feed/payload_metadata.proto
@@ -19,7 +19,6 @@
option optimize_for=LITE_RUNTIME;
import "src/main/proto/search/now/wire/feed/content_id.proto";
-import "src/main/proto/search/now/wire/feed/semantic_properties.proto";
option java_package = "com.google.search.now.wire.feed";
option java_outer_classname = "PayloadMetadataProto";
@@ -29,8 +28,5 @@
// The unique identifier of the payload.
optional ContentId content_id = 1;
- // Payload semantic properties
- optional SemanticProperties semantic_properties = 2;
-
- reserved 3;
+ reserved 2, 3;
}
diff --git a/src/main/proto/search/now/wire/feed/semantic_properties.proto b/src/main/proto/search/now/wire/feed/semantic_properties.proto
deleted file mode 100644
index 6885963..0000000
--- a/src/main/proto/search/now/wire/feed/semantic_properties.proto
+++ /dev/null
@@ -1,32 +0,0 @@
-// Copyright 2018 The Feed Authors.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-syntax = "proto2";
-
-
-package search.now.wire.feed;
-
-option optimize_for=LITE_RUNTIME;
-
-option java_package = "com.google.search.now.wire.feed";
-option java_outer_classname = "SemanticPropertiesProto";
-
-// SemanticProperties hold semantic information that we want to attach to
-// features for subsequent comparisons. For example, a feature might be
-// associated with a specific "mid".
-message SemanticProperties {
- // This is kept opaque to Feed - we want to keep it and send it alongside
- // content ids in requests
- optional bytes semantic_properties_data = 1;
-}
