| commit | 8b6bbfc8104e5015735e36c577b072bdfbb7326d | [log] [tgz] |
|---|---|---|
| author | Aaron Gable <agable@chromium.org> | Wed Jan 31 00:41:41 2018 |
| committer | Aaron Gable <agable@chromium.org> | Wed Jan 31 00:44:20 2018 |
| tree | dccc2e71caa4e56bc30940785bb14cd4e426cc6e | |
| parent | 283b806d9b601269e9d34acfe92758486b19136a [diff] |
Autofocus filter input when opening overlay This is only a partial solution: although the input element will be focused the first time the overlay is opened, it doesn't become focused on future openings. This is despite the fact that iron-overlay-behavior (which the parent element, gr-overlay, imports) explicitly has support for focusing any [autofocus] elements. It's not clear why that isn't working as expected. R=seanmccullough Bug: 806971 Change-Id: I572b4a491a8de7cd46b0a583417c6d43c4a2373a Reviewed-on: https://chromium-review.googlesource.com/894845 Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
This plugin is configured via the buildbucket.config file present in the repo‘s refs/meta/config ref, as well as the same file in all repositories in the repo’s inheritance chain (up to and including All-Projects).
An example buildbucket.config is below:
[host] git = "chromium.googlesource.com" gerrit = "chromium-review.googlesource.com" [bucket "chromium.buildbucket.swarming"] builder = infra_presubmit builder = infra_linux64 builder = infra_mac builder = infra_win [bucket "tryserver.infra"] builder = Infra Presubmit builder = Infra Linux Trusty 64 Tester builder = Infra Linux Precise 32 Tester builder = Infra Mac Tester builder = Infra Win Tester
In the vast majority of cases, the host.git and host.gerrit values are global to the entire host, so that stanza is specified in the All-Projects repo. Buckets and builders, on the other hand, are almost always very repository-specific, and so are only specified in “leaf” repositories which are not in any other repo's inheritance chain.
All changes to buildbucket.config files are instantly reflected. There is no caching period or need to restart the server.
ln -s /path/to/buildbucket-plugin plugins/buildbucket bazel build plugins/buildbucket && \ rm -rf ../gerrit_testsite/plugins/buildbucket.jar && \ cp bazel-genfiles/plugins/buildbucket/buildbucket.jar ../gerrit_testsite/plugins/ && \ ../gerrit_testsite/bin/gerrit.sh restart
Use the script run-with-prod-data.sh; this creates a temporary directory with the plugin source in the expected layout and then invokes polygerrit-ui/run-server.sh. Example invocation:
GERRIT=~/gerrit ./run-with-prod-data.sh
# Install dependencies. npm install -g bower npm install -g web-component-tester cd test/ bower install # Run the tests from the directory root. cd ../ wct
Note: Testing is disabled for Safari due to this issue.